-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add optional nickname parameter to orders #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sinedied <[email protected]>
Co-authored-by: sinedied <[email protected]>
Copilot
AI
changed the title
[WIP] Add optional nickname parameter to orders
Add optional nickname parameter to orders
Oct 9, 2025
Copilot finished work on behalf of
sinedied
October 9, 2025 08:46
sinedied
requested changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks requested.
And display 10 chars instead of 8 when using a nickname.
Contributor
|
Minor tweaks requested:
|
Co-authored-by: sinedied <[email protected]>
Author
All changes implemented in ffab616:
|
Copilot finished work on behalf of
sinedied
October 9, 2025 10:10
sinedied
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds an optional
nicknameparameter when placing orders. When provided, the burger-webapp dashboard displays the first 10 characters of the nickname instead of the order ID, making it easier for customers to identify their orders.Changes
Display Behavior
Before: Orders always showed the last 6 characters of the auto-generated order ID with # prefix (e.g.,
#abcdef)After: Orders show the first 10 characters of the nickname if provided (e.g.,
Alicewithout # prefix), otherwise fall back to the order ID with # prefix (e.g.,#abcdef)Implementation
Added
nicknameas an optional field throughout the order lifecycle:API Layer:
Orderinterface withnickname?: stringCreateOrderRequestto accept optional nicknameFrontend Layer:
BurgerOrderinterfaceMCP Layer:
place_ordertool schema to accept optional nickname parameterExample Usage
Backward Compatibility
✅ Fully backward compatible - The nickname parameter is optional, so all existing code and integrations continue to work without any changes. Orders without nicknames display exactly as before.
Files Changed
packages/burger-api/src/order.tspackages/burger-api/src/functions/orders-post.tspackages/burger-api/openapi.yamlpackages/burger-api/api.httppackages/burger-webapp/src/orders.service.tspackages/burger-webapp/src/components/burger-dashboard.tspackages/burger-mcp/src/tools.tsFixes #3
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.